Phase C: automatic carry - #31
Merged
Merged
Conversation
Unfinished TODOs on the most recent past log day now carry forward automatically on the first write of a new day: fresh hashes, a carriedFrom pointer back to the source item, and the source day frozen read-only. logfile.Update no longer self-rejects writing a frozen body (the only way carry could ever persist the freeze it just performed), so del gains its own explicit freeze check instead.
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
carriedFrompointer back to the source itemlogfile.Updateno longer self-rejects writing a frozen body (previously the only way to persist a freeze), moving the write-guard to callers —delgains its own explicit freeze check for its past-day writescarriedFromexistsTest plan
go build ./...,go vet ./...,gofmt -l .,golangci-lint run ./...go test ./...(new coverage: carry trigger/skip/gap-day/once-per-day ininternal/command,CarryForwardininternal/log, frozen-body persistence ininternal/logfile, CLI end-to-end incmd/sava)